Check for strange expressions like
This is a heuristic for generating warnings, inspired by PVS Studio. It has found a few pretty minor things that we were able to clean up, and also found one interesting copy/paste bug.
We look for identical sub-expressions on the left and right of most binary
operations, for instance
We also look for part-selects that use the same expressions for both
indices, e.g.,